Fix up AttributeTypeSyntax handling #1086
Merged
+136
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
allevato,
hamishknight and
rintaro
as code owners
bnbarham
commented
Nov 11, 2025
There's a few issues here: 1. Type specifiers can now have arguments (eg. `nonisolated(nonsending)`) 2. Some type specifiers can be specified "late", which are currently unhandled 3. We were using a mix of `.same` and `.continue` breaks (`.continue` for specifiers and `.same` for attributes) 4. Attributes were grouped separately to specifiers Fixes swiftlang#1081
bnbarham
force-pushed
the
specifiers-with-params
branch
from
24d2533 to
b2091bd
Compare
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Nov 12, 2025
Adjust formatting to account for swiftlang/swift-format#1086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few issues here:
nonisolated(nonsending)).sameand.continuebreaks (.continuefor specifiers and.samefor attributes)Fixes #1081