Prevent accessing unicode scalar element with incorrect index. #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiaromorales
force-pushed
the
r150760264/percent-encoded-character
branch
from
41942f2 to
be12879
Compare
sofiaromorales
requested review from
d-ronnqvist,
QuietMisdreavus,
patshaughnessy and
anferbui
d-ronnqvist
reviewed
May 8, 2025
sofiaromorales
force-pushed
the
r150760264/percent-encoded-character
branch
2 times, most recently
from
4f3fc97 to
6fe73e7
Compare
sofiaromorales
force-pushed
the
r150760264/percent-encoded-character
branch
from
6fe73e7 to
5b39673
Compare
|
@swift-ci please test |
| // Create a new string by mapping over the character helps | ||
| // preventing crashes when handling substrings that contains | ||
| // multibyte characters. | ||
| self.map { String($0) }.joined() |
There was a problem hiding this comment.
Is this change necessary?
If so, what are the performance implications of this? Reading this naively it seems like it could be horribly slow. But I'm not familiar with how Swift implements strings and sub-strings internally. We should run a benchmark to make sure this isn't a hot spot.
There was a problem hiding this comment.
I changed it back. Linux environments don't like constructing strings from substrings that contains multibyte characters and sometimes it results in crashes, but it's true that this has performance issues.
QuietMisdreavus
previously requested changes
May 9, 2025
There was a problem hiding this comment.
One request, one suggestion, and i'm also interested in @patshaughnessy's question.
sofiaromorales
force-pushed
the
r150760264/percent-encoded-character
branch
from
b671925 to
1f92a91
Compare
|
@swift-ci please test |
sofiaromorales
force-pushed
the
r150760264/percent-encoded-character
branch
from
1f92a91 to
435b602
Compare
sofiaromorales
force-pushed
the
r150760264/percent-encoded-character
branch
from
435b602 to
45919d3
Compare
anferbui
approved these changes
May 14, 2025
This change prevents a potential DocC crash by making sure that it does not access an array element using an index that is outside of the bonds of the array. `.index(after:` can crash in some cases if the passed index belongs to the last element of the collection. with this change we ensure that the passed index is not the last index. rdar://150760264
sofiaromorales
force-pushed
the
r150760264/percent-encoded-character
branch
from
45919d3 to
4babd33
Compare
|
@swift-ci please test |
sofiaromorales
dismissed
QuietMisdreavus’s stale review
I added the requested changes, thx!
d-ronnqvist
approved these changes
May 14, 2025
sofiaromorales
added a commit
to sofiaromorales/swift-docc
that referenced
this pull request
May 15, 2025
…lang#1214) This change prevents a potential DocC crash by making sure that it does not access an array element using an index that is outside of the bonds of the array. `.index(after:` can crash in some cases if the passed index belongs to the last element of the collection. with this change we ensure that the passed index is not the last index. rdar://150760264
sofiaromorales
added a commit
that referenced
this pull request
May 15, 2025
#1219) This change prevents a potential DocC crash by making sure that it does not access an array element using an index that is outside of the bonds of the array. `.index(after:` can crash in some cases if the passed index belongs to the last element of the collection. with this change we ensure that the passed index is not the last index. rdar://150760264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 150760264
Summary
This change prevents a potential DocC crash by making sure that it does not access an array element using an index that is outside of the bonds of the array.
.index(after:can crash in some cases if the passed index belongs to the last element of the collection. with this change we ensure that the passed index is not the last index.Testing
Run unit tests in Linux using Swift 5.9.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded