Add SwiftASN1 as dep in CMakeLists file #2139
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftPM has added Crypto related functionality to Workspace to support signing of the swift-syntax prebuilts manifest signing. This breaks sourcekit-lsp builds on Windows complaining about SwiftASN1 being missing. Adding a clause here to match the one in SwiftPM's CMakeLists.txt file.
|
Related SwiftPM PR: swiftlang/swift-package-manager#8610 |
ahoppen
approved these changes
May 7, 2025
There was a problem hiding this comment.
Do you also need to add corresponding search paths here so that we can find ASN1 when running SourceKit-LSP tests on Windows? https://github.com/swiftlang/swift/blob/88de66523c786d16a6cf43e5f9798ce27118594d/utils/build.ps1#L2948
|
Yup, thanks! |
|
@swift-ci please test |
|
@ahoppen can I get this merged? (Also why can't I do that?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftPM has added Crypto related functionality to Workspace to support signing of the swift-syntax prebuilts manifest signing. This breaks sourcekit-lsp builds on Windows complaining about SwiftASN1 being missing. Adding a clause here to match the one in SwiftPM's CMakeLists.txt file.