Log contextual requests that affect sourcekitd’s global state #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
contextual-sourcekitd-request
branch
2 times, most recently
from
b8a09b5 to
c0cd2ac
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
contextual-sourcekitd-request
branch
from
c0cd2ac to
e481ad5
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
reviewed
May 9, 2025
This way we can log them when a sourcekitd request crashes and we can thus replay these contextual requests when diagnosing the crash.
Teach `sourcekit-lsp diagnose` how to extract contextual requests from the system log and use them to reduce sourcekitd crashes.
ahoppen
force-pushed
the
contextual-sourcekitd-request
branch
from
e481ad5 to
d63419d
Compare
bnbarham
approved these changes
May 12, 2025
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can log them when a sourcekitd request crashes and we can thus replay these contextual requests when diagnosing the crash.