[clang][Dependency Scanning] Cherry-picking Negative Stat Caching Diagnostics in Dependency Scanning Service #10681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve Stat Cache Entries (llvm#135703) We have had numerous situations where the negatively stat cached paths are invalidated during the build, and such invalidations lead to build errors. This PR adds an API to diagnose such cases. `DependencyScanningFilesystemSharedCache::diagnoseNegativeStatCachedPaths` allows users of the cache to ask the cache to examine all negatively stat cached paths, and re-stat the paths using the passed-in file system. If any re-stat succeeds, the API emits diagnostics. rdar://149147920 (cherry picked from commit 9ef9167) Conflicts: clang/unittests/Tooling/DependencyScanning/DependencyScanningFilesystemTest.cpp
…lvm#10524) llvm#135703 added a C++ API to the shared cached to diagnose invalid negatively stat cached paths. This PR adds a C API so an external system can take advantage of the diagnostics. rdar://149147920 (cherry picked from commit b7aa45c)
llvm#138955) This PR makes a minor modification to make it more stable. The only change is adding a suffix to the path under test. rdar://149147920 (cherry picked from commit 2017831)
|
@swift-ci please test |
jansvoboda11
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks
llvm#135703
#10524
llvm#138955
These PRs implement clang's C-API to report invalid negatively stat cached paths.
rdar://149147920