Skip to content

Make RequestBag conform to Sendable #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Make RequestBag conform to Sendable #837

merged 1 commit into from
Apr 30, 2025

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Apr 30, 2025

Motivation:

RequestBag conforms to HTTPExecutableRequest to must be Sendable.

Modifications:

  • Move event-loop bound state to a loop-bound box
  • Remove redundant event-loop checks (they are performed by the loop bound box)

Result:

Fewer warnings

@glbrntt
Make RequestBag conform to Sendable
077fcb3 
Motivation:

RequestBag conforms to HTTPExecutableRequest to must be Sendable.

Modifications:

- Move event-loop bound state to a loop-bound box
- Remove redundant event-loop checks (they are performed by the loop
  bound box)

Result:

Fewer warnings
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Apr 30, 2025
@glbrntt glbrntt enabled auto-merge (squash) April 30, 2025 09:43
@glbrntt glbrntt merged commit c61298e into swift-server:main Apr 30, 2025
24 of 25 checks passed
@glbrntt glbrntt deleted the strict-request-bag branch April 30, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjcairo gjcairo gjcairo approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @gjcairo