Skip to content

Commit

Permalink
refactor: Remove separate button to validate flightplan
Browse files Browse the repository at this point in the history
The flightplan is already automatically validated when sending it to the
server. To simplify the UI, this removes the possibility for this extra check.
  • Loading branch information
ltoenning committed Mar 24, 2024
1 parent f7bee83 commit ce5efaf
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 23 deletions.
8 changes: 0 additions & 8 deletions src/blackgui/components/flightplancomponent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ namespace BlackGui::Components
connect(ui->pb_Send, &QPushButton::pressed, this, &CFlightPlanComponent::sendFlightPlan, Qt::QueuedConnection);
connect(ui->pb_Download, &QPushButton::pressed, this, &CFlightPlanComponent::loadFlightPlanFromNetwork, Qt::QueuedConnection);
connect(ui->pb_Reset, &QPushButton::pressed, this, &CFlightPlanComponent::resetFlightPlan, Qt::QueuedConnection);
connect(ui->pb_ValidateFlightPlan, &QPushButton::pressed, this, &CFlightPlanComponent::validateFlightPlan, Qt::QueuedConnection);
connect(ui->tb_SyncWithSimulator, &QPushButton::released, this, &CFlightPlanComponent::syncWithSimulator, Qt::QueuedConnection);
connect(ui->pb_Prefill, &QPushButton::pressed, this, &CFlightPlanComponent::anticipateValues, Qt::QueuedConnection);
connect(ui->pb_SimBrief, &QPushButton::pressed, this, &CFlightPlanComponent::loadFromSimBrief, Qt::QueuedConnection);
Expand Down Expand Up @@ -528,13 +527,6 @@ namespace BlackGui::Components
}
}

void CFlightPlanComponent::validateFlightPlan()
{
CFlightPlan flightPlan;
const CStatusMessageList messages = this->validateAndInitializeFlightPlan(flightPlan);
this->showOverlayMessages(messages);
}

void CFlightPlanComponent::resetFlightPlan()
{
this->prefillWithOwnAircraftData();
Expand Down
3 changes: 0 additions & 3 deletions src/blackgui/components/flightplancomponent.h
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,6 @@ namespace BlackGui::Components
//! Load Flightplan
void loadFlightPlanFromNetwork();

//! Validate Flightplan
void validateFlightPlan();

//! Remarks
void buildRemarksString();

Expand Down
12 changes: 0 additions & 12 deletions src/blackgui/components/flightplancomponent.ui
Original file line number Diff line number Diff line change
Expand Up @@ -708,17 +708,6 @@
</property>
</widget>
</item>
<item row="0" column="2">
<widget class="QPushButton" name="pb_ValidateFlightPlan">
<property name="text">
<string>&amp;Validate</string>
</property>
<property name="icon">
<iconset resource="../../blackmisc/blackmisc.qrc">
<normaloff>:/diagona/icons/diagona/icons/abacus.png</normaloff>:/diagona/icons/diagona/icons/abacus.png</iconset>
</property>
</widget>
</item>
<item row="2" column="1">
<widget class="QPushButton" name="pb_LoadDisk">
<property name="toolTip">
Expand Down Expand Up @@ -1168,7 +1157,6 @@
<tabstop>le_LastSent</tabstop>
<tabstop>pb_Prefill</tabstop>
<tabstop>pb_Reset</tabstop>
<tabstop>pb_ValidateFlightPlan</tabstop>
<tabstop>pb_Send</tabstop>
<tabstop>pb_Download</tabstop>
<tabstop>pb_SimBrief</tabstop>
Expand Down

0 comments on commit ce5efaf

Please sign in to comment.