Skip to content
This repository was archived by the owner on Apr 13, 2021. It is now read-only.

Conversation

@rge-exafore
Copy link
Contributor

No description provided.

@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/piksi_firmware_Pull_Requests/972/

src/Makefile Outdated
empty :=
space := $(empty) $(empty)
GIT_VERSION := $(subst $(space),$(dash),$(GIT_VERSION))
$(info $(GIT_VERSION))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a debug statement? Some more information may be?

@valeri-atamaniouk
Copy link

looks good

@ljbade
Copy link
Contributor

ljbade commented May 27, 2016

Looks OK to me, what do the new version string look like?

@rge-exafore rge-exafore force-pushed the version-commits-time branch from 4f0a962 to 9d412b4 Compare June 1, 2016 08:06
@swiftnav-jenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/piksi_firmware_Pull_Requests/985/

@jacobmcnamee
Copy link
Contributor

The submodule commit IDs are implicitly captured by the piksi_firmware commit ID. What is the motivation for including the libswiftnav commit ID explicitly?

@rge-exafore
Copy link
Contributor Author

libswiftnav changes more frequently than other submodules that's why including it explicitly. (But including all submodules' commit ids would be even better.) This ensures that the build can be restored even if submodule pointer wasn't moved or public version of libswiftnav was replaced with private or vice versa.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants