Closed
Conversation
JADC362
force-pushed
the
jadc362/add_new_function
branch
from
abd91a6 to
7b415d6
Compare
JADC362
force-pushed
the
jadc362/add_new_function
branch
from
f8877e7 to
df8361e
Compare
jbangelo
approved these changes
Jul 9, 2025
Contributor
jbangelo
left a comment
jbangelo
left a comment
There was a problem hiding this comment.
Looks good, just one style change
Comment on lines
+275
to
+280
| /** | ||
| * @brief Converts a decimal year to a MJD (modified Julian date). | ||
| * | ||
| * @param epoch_years The epoch in decimal years representation. | ||
| * @return The epoch in MJD representation. | ||
| */ |
Contributor
There was a problem hiding this comment.
The style in this repo is to put the documentation comments into the source file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
Design Notes
decimal_years_to_gps_timetolibswiftnav->gnss_time.gps_time_to_decimal_yearstolibswiftnav->gnss_time.decimal_year_to_mjdtolibswiftnav->gnss_time.Testing
Related PRs