Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite a file that is used later #1363

Closed
wants to merge 1 commit into from

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Feb 13, 2023

Make a copy of the file.

@bkmgit bkmgit closed this Feb 13, 2023
@bkmgit bkmgit reopened this Feb 13, 2023
@gcapes
Copy link
Contributor

gcapes commented Feb 15, 2023

Thanks for the PR.
This is a callout showing what not to do. So I'm afraid that changing the example to a better practice negates the point of the callout.

Copy link
Contributor

@emcaulay emcaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This edit to the episode 4 addresses a concern raised and discussed in issue #1375 . I recommend accepted and merging these changes in.

I just realized this PR is already closed, so my comment here is after the fact!

@emcaulay
Copy link
Contributor

emcaulay commented Mar 9, 2023

Now, I'm seeing that this PR was not accepted, but I do think it is a good revision and addresses the concern discussed in #1375. I think it seems a little cruel to set up a learner to destroy a file by mistake when we expect them to have the intact file for continuing the lesson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants