This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
zext-screencopy-unstable-v1 #3320
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a glue file to allow integration with builds.sr.ht.
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3320 |
For `required` to disable search the value needs to be of `feature` type. Checking `gles2` via `in` keyword returns a `bool` but `required: false` makes the dependency optional instead of disabled.
This allows compositors to handle touch pointer emulation manually, instead of having Xwayland do it [1]. [1]: https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/691
This struct contains additional information for session device change events, such as the DRM connector ID that has changed.
When a connector ID is specified in a hotplug event, don't scan all connectors. Only scan the connector that has changed.
Callers can access output->front_buffer instead.
The protocol uses a signed integer here, which is also what the wlr_input_method_v2_preedit_string struct provides to compositors from the input method protocol. Sway currently just passes those int32_t values directly to this function leading to an implicit conversion.
Closes #3324.
Removing an input device requires unlinking it from the list of all headless input devices. For that implement a destroy function.
We were send a protocol error if INTERLACED or BOTTOM_FIRST was set. This is incorrect for the zwp_linux_dmabuf_params.create code-path because this kills the client without allowing it to gracefully handle the error. We should only send a protocol error if the client provides a bit not listed in the protocol definition.
They are never used in practice, which makes all of our flag handling effectively dead code. Also, APIs such as KMS don't provide a good way to deal with the flags. Let's just fail the DMA-BUF import when clients provide flags.
A wlroots user can easily get confused and think that `cap` refers to wlroots buffer capabilities, not array capacity.
Co-authored-by: Simon Zeni <[email protected]>
This reverts commit 4fe62d0.
any1
force-pushed
the
zext-screencopy-unstable-v1
branch
from
9bed12b to
eaf5b69
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of a new screencopy protocol which integrates most of the requirements which we have discussed in the past. It should also be possible to extend it to capture top-levels.
The new protocol is modelled after
wl_surface. This model should make it easier to extend the protocol in the future.wayland-protocols PR: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/124
Supersedes: #2329, #3166, swaywm/wlr-protocols#105
cc @emersion, @columbarius, @quantum5