This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
surface: add WLR_SURFACE_STATE_SUBSURFACES #3170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to figure out when the subsurface list has changed: subsurface added, removed, or re-ordered. In the case where the subsurface list hasn't changed, some book-keeping operations can be skipped.
Also add a small TODO.
vyivel
reviewed
Sep 6, 2021
| @@ -698,6 +701,7 @@ static void subsurface_destroy(struct wlr_subsurface *subsurface) { | |||
| wl_list_remove(&subsurface->surface_destroy.link); | |||
|
|
|||
| if (subsurface->parent) { | |||
| subsurface->parent->pending.committed |= WLR_SURFACE_STATE_SUBSURFACES; | |||
There was a problem hiding this comment.
Subsurfaces are destroyed instantly, their removal isn't double-buffered.
There was a problem hiding this comment.
Yes, but I'd still like to give the caller a chance to figure out that the subsurface list changed…
There was a problem hiding this comment.
I think callers should simply listen to new_subsurface/destroy signals, and WLR_SURFACE_STATE_SUBSURFACES should be left as an optimization thing.
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3170 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to figure out when the subsurface list has changed:
subsurface added, removed, or re-ordered. In the case where
the subsurface list hasn't changed, some book-keeping operations
can be skipped.
Useful for #3128
cc @vyivel