xdg-shell: dont overwrite for_window scratchpad geometry #8927
+3
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bash script works now without the second wait. Maybe the issue runs deeper because |
|
I tested 4aaff7e2ef61b523629f80abfed0d784057c6411 with |
Contributor
Author
|
Non-terminal windows should also get matched. lmk if that's not the case (it is for me). |
sahinf
force-pushed
the
for_window-ignored
branch
from
f528de5 to
1473132
Compare
this handle_commit causes containers in the scratchpad to have their `for_window` resize geometry get reset by natural geometry. A for_window ... resize directive's call to schedule ends up overwritten by this commit with natural geometry values.
floating criteria get parsed and added to the config criteria list but rejected by 1e9aaa5
forces for_window floating enable to render immediately rather than on mouse click / keyboard focus. fixes swaywm#8711
sahinf
force-pushed
the
for_window-ignored
branch
from
1473132 to
2f776c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8493, fixes #8018, fixes #8711