Added suport for parsing comments inside of function bodies #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2024 16:02
- added documentation for --parseFuncBody flag (changed) main.go - added --parseFuncBody flag flag (changed) gen.go - added ParseFuncBody to Config struct (changed) parser_test.go - added tests for ParseRouterAPIInfo changes to parse comments inside of functions (changed) parser.go - added ParseFuncBody to Parser struct - modified ParseRouterAPIInfo to parse comments from AstFileInfo.File.Comments instead of from AstFileInfo..File.Decls[].Doc.List if parser.ParseFuncBody set to true - moved logic for comment parsing from ParseRouterAPIInfo to parseRouterAPIInfoComment - moved fileInfo.ParseFlag & ParseOperations checks to top of function with early return
sdghchj
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
I have updated
ParseRouterAPIInfo()to parse API info from comments inside of function bodies if the new CLI flagParseFuncBodyis used.Relation issue
Implements idea detailed here: #1809
Additional context
This change is opt-in only as the new CLI flag
ParseFuncBodymust be used to get the new functionality. This will have no impact on existing users.