Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: allow enum ordered const name override #1779

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

drewsilcock
Copy link

Describe the PR
Add ability to override name of enum variant generated from ordered constant using // @name VariantName in the same way you can do for types.

Relation issue
#1778

Additional context
N/A

const.go Outdated Show resolved Hide resolved
types.go Outdated Show resolved Hide resolved
@ubogdan
Copy link
Contributor

ubogdan commented Apr 21, 2024

@drewsilcock Please rebase and update the code.

@drewsilcock drewsilcock force-pushed the feature/allow-enum-ordered-const-name-override branch from 1443dbf to 61ef538 Compare April 29, 2024 10:54
@drewsilcock
Copy link
Author

Thanks for taking the time to take a look at this @ubogdan - I've rebased and updated based on the linter and your comments.

@drewsilcock drewsilcock requested a review from ubogdan June 10, 2024 14:29
@drewsilcock
Copy link
Author

@ubogdan @sdghchj Any chance of a re-review / merge? Would be great to get this in. Thanks in advance 🙂

@sdghchj
Copy link
Member

sdghchj commented Jul 5, 2024

I can't see the passed checks of all the tests.
I am afraid I will be noticed again the test failure if I merge this PR.

@drewsilcock
Copy link
Author

I can't see the passed checks of all the tests. I am afraid I will be noticed again the test failure if I merge this PR.

Is there something additional we need to do for the full test suite to run on this PR? (The tests pass just fine when I run it locally on Go v1.22.)

@sdghchj
Copy link
Member

sdghchj commented Jul 6, 2024

@ubogdan was requested to review。
long time no see him.

@drewsilcock
Copy link
Author

Thanks for approving, I re-requested a review from @ubogdan after making the changes he requested, is his approval required for merging? GitHub seems to be blocking merge until the review request is approved or dismissed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants