Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comments on some exported functions for lint check #1724

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Dec 18, 2023

Describe the PR
fix comments on some exported functions for lint check

Signed-off-by: sdghchj <[email protected]>
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6cdaaf5) 83.52% compared to head (7df7753) 83.18%.
Report is 2 commits behind head on master.

Files Patch % Lines
parser.go 11.11% 7 Missing and 1 partial ⚠️
operation.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1724      +/-   ##
==========================================
- Coverage   83.52%   83.18%   -0.34%     
==========================================
  Files          19       16       -3     
  Lines        3823     3806      -17     
==========================================
- Hits         3193     3166      -27     
- Misses        534      543       +9     
- Partials       96       97       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdghchj sdghchj requested a review from ubogdan December 18, 2023 09:00
@sdghchj
Copy link
Member Author

sdghchj commented Dec 19, 2023

@ubogdan Give me a hand, approve

@ubogdan ubogdan merged commit 9fdba3e into master Dec 19, 2023
10 of 12 checks passed
@ubogdan ubogdan deleted the fix_comment_on_exported_func branch December 19, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants