🐛 array form filed name should not contains bracket which led to invalid fieldname in ts codegen #1706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Change FormName. Trim bracket in filedname
Relation issue
e.g. https://github.com/swaggo/swag/pull/118/files
Additional context
In gin binding, an array parameter goes like
In swaggo/swag less than v1.8.10, it's field name should comes from ps.Filed.Names[0] which is "Names", which goes to toLowerCamelCase and generate "names".
Since v1.8.11, FormName was introduced to parse form tag, which generates
books[]
tags, which lead to bad codegen in ts.Ts code changes, which is not generated by tools, write by hand.
From:
To:
Teacher."books[]"
is not working in ts, which only can be use likeTeacher["books[]"]
.