Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the docker container has to be invoked with
docker run --rm -v $(pwd):/code -w /code ghcr.io/swaggo/swag:v1.16.2 /root/swag
which means users have to know that the binary is placed under
/root/swag
. If they don´t know this and just trydocker run --rm -v $(pwd):/code ghcr.io/swaggo/swag:v1.16.2
they will get the error
docker: Error response from daemon: No command specified.
if they then try
docker run --rm -v $(pwd):/code ghcr.io/swaggo/swag:v1.16.2 swag
it won´t work either
This PR adds an
ENTRYPOINT
meaning the first command will just work. It also moves the binary to/bin
since having the binary in the same directory as the defaultWORKDIR
is suboptimal since users need to mount their code into the container. If the binary is not stored in theWORKDIR
, then users can simply mount their code to that directory without having to specify a different one with-w
.