fix required params parsing for routes with multiple paths and multiple params #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubogdan
requested changes
Jul 6, 2023
parser.go
Outdated
| *op = &operation.Operation | ||
| if len(operation.RouterProperties) > 1 { | ||
| newOp := *operation | ||
| validParams := []spec.Parameter{} |
There was a problem hiding this comment.
Please use var validParams []spec.Parameter in order to avoid mem allocations.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1621 +/- ##
==========================================
- Coverage 83.76% 83.70% -0.06%
==========================================
Files 19 17 -2
Lines 3752 3726 -26
==========================================
- Hits 3143 3119 -24
+ Misses 521 519 -2
Partials 88 88
☔ View full report in Codecov by Sentry. |
ubogdan
approved these changes
Jul 7, 2023
|
@Phenix66 Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fixes #1267
Relation issue
e.g. https://github.com/swaggo/swag/pull/118/files
Additional context
Add any other context about the problem here.