Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat servers variables of current spec #1612

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

nonchan7720
Copy link

@nonchan7720 nonchan7720 commented Jun 26, 2023

Describe the PR
Support for servers.variables.xxx

Relation issue
#1611

Additional context

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 35.89% and project coverage change: -0.22 ⚠️

Comparison is base (60ef6b7) 79.38% compared to head (a4978c3) 79.17%.

❗ Current head a4978c3 differs from pull request most recent head f9c2ffc. Consider uploading reports for the commit f9c2ffc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1612      +/-   ##
==========================================
- Coverage   79.38%   79.17%   -0.22%     
==========================================
  Files          21       21              
  Lines        5570     5605      +35     
==========================================
+ Hits         4422     4438      +16     
- Misses        974      991      +17     
- Partials      174      176       +2     
Impacted Files Coverage Δ
parserv3.go 72.54% <35.89%> (-1.55%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 0709499 into swaggo:v2 Jul 18, 2023
7 checks passed
@ubogdan
Copy link
Contributor

ubogdan commented Jul 18, 2023

@nonchan7720 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants