Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: enums of underscored number #1581

Merged
merged 1 commit into from
May 12, 2023
Merged

fix bug: enums of underscored number #1581

merged 1 commit into from
May 12, 2023

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented May 6, 2023

Describe the PR
support enums of underscored number

Relation issue
#1580

@sdghchj sdghchj requested a review from ubogdan May 6, 2023 01:22
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5774b7b) 83.79% compared to head (97189ae) 83.80%.

❗ Current head 97189ae differs from pull request most recent head 9ff5016. Consider uploading reports for the commit 9ff5016 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1581   +/-   ##
=======================================
  Coverage   83.79%   83.80%           
=======================================
  Files          19       19           
  Lines        3745     3747    +2     
=======================================
+ Hits         3138     3140    +2     
  Misses        520      520           
  Partials       87       87           
Impacted Files Coverage Δ
package.go 73.33% <100.00%> (+0.51%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ubogdan
Copy link
Contributor

ubogdan commented May 6, 2023

Please take into consideration that @Nerzal is making efforts to finish v2 (OAS3 integration). These fixes sometimes create conflicts that are hard to manage via rebase.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unit tests are missing :)

@Nerzal
Copy link
Contributor

Nerzal commented May 8, 2023

I try to keep track of what needs to be merged & reimplemented into V2 branch, so no worries.

@sdghchj sdghchj merged commit ea35767 into master May 12, 2023
@sdghchj sdghchj deleted the underscored_const branch May 12, 2023 01:32
Nerzal pushed a commit that referenced this pull request May 25, 2023
sdghchj added a commit that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants