-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gradle-plugin): enable lazy evaluation, implicit task dependencies and fixing setEncoding
#4761
Merged
frantuma
merged 1 commit into
swagger-api:master
from
nbrugger-tgm:gradle/enable-lazy-configuration
Dec 11, 2024
Merged
feat(gradle-plugin): enable lazy evaluation, implicit task dependencies and fixing setEncoding
#4761
frantuma
merged 1 commit into
swagger-api:master
from
nbrugger-tgm:gradle/enable-lazy-configuration
Dec 11, 2024
+300
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrugger-tgm
changed the title
feat(gradle-plugin): enable lazy evaluation, implicit task dependencies
feat(gradle-plugin): enable lazy evaluation, implicit task dependencies and fixing Oct 17, 2024
setEncoding
This was referenced Oct 17, 2024
nbrugger-tgm
force-pushed
the
gradle/enable-lazy-configuration
branch
2 times, most recently
from
October 18, 2024 07:53
57c56d2
to
b7d4a37
Compare
Sorry for the force pushes, i had to fix the commit it had the wrong commiter was not signed and i messed up the commit message |
nbrugger-tgm
force-pushed
the
gradle/enable-lazy-configuration
branch
from
October 28, 2024 15:51
1427fbb
to
22301bb
Compare
frantuma
force-pushed
the
gradle/enable-lazy-configuration
branch
from
October 28, 2024 16:55
22301bb
to
27331ce
Compare
Thanks @nbrugger-tgm , we'll try to take a look as soon as we can, we appreciate the code! |
frantuma
force-pushed
the
gradle/enable-lazy-configuration
branch
from
December 4, 2024 10:01
27331ce
to
3d4c54a
Compare
changes: - enable lazy evaluation by - replacing all Task configurations with gradles Property types - using `register` instead of `create` to register the task - remove wrongly set task dependencies that can cause circular dependencies. Task dependencies are now inferred by the set classpath. When gradle detects that an output of a task (like compileJava) is used an automatic dependency is formed and `resolve` will always execute compileJava first. The advantage is that this is dynamic. If one does NOT want `compileJava` to be executed it won't be as soon as nothing of compileJava is on the configured classpath
frantuma
force-pushed
the
gradle/enable-lazy-configuration
branch
from
December 11, 2024 14:28
3d4c54a
to
1746ab0
Compare
frantuma
approved these changes
Dec 11, 2024
Thanks! |
ndwlocatieservices
added a commit
to ndwnu/nls-accessibility-map
that referenced
this pull request
Dec 19, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.locationdataissuesapi:client-feign](https://dev.azure.com/ndwnu/NLS/_git/nls-location-data-issues) ([source](https://dev.azure.com/ndwnu/NLS/_git/nls-location-data-issues)) | compile | patch | `1.0.14` -> `1.0.15` | | nu.ndw.nls.geojson.geometry:specification | | patch | `1.3.5` -> `1.3.8` | | nu.ndw.nls.geojson.geometry:specification-open-api-config | | patch | `1.3.5` -> `1.3.8` | | nu.ndw.nls.geojson.geometry:geometry-model | compile | patch | `1.3.5` -> `1.3.8` | | nu.ndw.nls.geojson.geometry:specification | compile | patch | `1.3.5` -> `1.3.8` | | nu.ndw.nls.geojson.geometry:geometry-jts | compile | patch | `1.3.5` -> `1.3.8` | | [nu.ndw.nls:routing-map-matcher-library](https://github.com/ndwnu/nls-routing-map-matcher) | compile | minor | `13.2.4` -> `13.3.0` | | [io.swagger.core.v3:swagger-annotations](https://github.com/swagger-api/swagger-core) | compile | patch | `2.2.26` -> `2.2.27` | --- ### Release Notes <details> <summary>swagger-api/swagger-core (io.swagger.core.v3:swagger-annotations)</summary> ### [`v2.2.27`](https://github.com/swagger-api/swagger-core/releases/tag/v2.2.27): Swagger-core 2.2.27 released! [Compare Source](swagger-api/swagger-core@v2.2.26...v2.2.27) - fix: swagger-api/swagger-ui#10220 ([#​4806](swagger-api/swagger-core#4806)) - Fix for record component annotations on fields with JsonProperty annotations ([#​4795](swagger-api/swagger-core#4795)) - Fix java.lang.NullPointerException and remove stack trace output from ModelResolver ([#​4793](swagger-api/swagger-core#4793)) - Move applySchemaResolution check to a method ([#​4791](swagger-api/swagger-core#4791)) - feat(gradle-plugin): enable lazy evaluation, implicit task dependencies and fixing `setEncoding` ([#​4761](swagger-api/swagger-core#4761)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Changes
register
instead ofcreate
to register the taskresolve
will always execute compileJava first. The advantage is that this is dynamic. If one does NOT wantcompileJava
to be executed it won't be as soon as nothing of compileJava is on the configured classpathFixes: #4366 #4367