Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSCode settings #3374

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Add VSCode settings #3374

merged 3 commits into from
Oct 1, 2023

Conversation

DeD1rk
Copy link
Member

@DeD1rk DeD1rk commented Sep 24, 2023

Closes #3371.

This checks in:

  • Recommended extensions for linting and formatting
  • Settings for those extensions
  • A launch config for manage.py runserver and test with debugger

How to test

Try working on concrexit on a laptop with only VSCode, and no python-specific configuration. The see that, if you follow the recommendations, you get format on save and the rigt linting out of the box.

- Recommended extensions for linting and formatting
- Settings for those extensions
- A launch config for manage.py runserver with debugger
@ColonelPhantom
Copy link
Contributor

Would it also be possible for this to deal with Poetry in some way?

@DeD1rk
Copy link
Member Author

DeD1rk commented Sep 24, 2023

I'm not sure. The poetry install location depends on user settings and the python version, so we can't hardcode the python interpreter path afaik.

@ColonelPhantom
Copy link
Contributor

It's possible to find the venv path with poetry env info -p, but I don't know if VSCode allows executing anything to find it. Also I'm guessing one still needs to install poetry (obviously), and then also do poetry install et al?

Maybe a bit cursed but one potential workaround could maybe be a 'setup' shellscript or similar that ensures poetry is setup, creates/updates the venv, and sets the correct path in the VSCode config file? Although that's very deep into magic territory.

@DeD1rk
Copy link
Member Author

DeD1rk commented Sep 24, 2023

Yep that all still needs to be done manually. We can automate that in codespaces though 😏

And remove the push hook that's not necessary with VSCode's branch protection warnings
@DeD1rk DeD1rk merged commit 2e9535f into master Oct 1, 2023
11 checks passed
@DeD1rk DeD1rk deleted the vscode-default-config branch October 1, 2023 13:05
@DeD1rk DeD1rk added the feature Issues regarding a complete new feature label Oct 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues regarding a complete new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide VSCode settings
3 participants