-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VSCode settings #3374
Add VSCode settings #3374
Conversation
- Recommended extensions for linting and formatting - Settings for those extensions - A launch config for manage.py runserver with debugger
f4ee402
to
56140a9
Compare
Would it also be possible for this to deal with Poetry in some way? |
I'm not sure. The poetry install location depends on user settings and the python version, so we can't hardcode the python interpreter path afaik. |
It's possible to find the venv path with Maybe a bit cursed but one potential workaround could maybe be a 'setup' shellscript or similar that ensures poetry is setup, creates/updates the venv, and sets the correct path in the VSCode config file? Although that's very deep into magic territory. |
Yep that all still needs to be done manually. We can automate that in codespaces though 😏 |
And remove the push hook that's not necessary with VSCode's branch protection warnings
Closes #3371.
This checks in:
How to test
Try working on concrexit on a laptop with only VSCode, and no python-specific configuration. The see that, if you follow the recommendations, you get format on save and the rigt linting out of the box.