Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample values #44

Merged
merged 7 commits into from
Feb 14, 2024
Merged

Sample values #44

merged 7 commits into from
Feb 14, 2024

Conversation

svrooij
Copy link
Owner

@svrooij svrooij commented Feb 13, 2024

Sample values

Description

Who doesn't need sample values? This enables the group effort to add sample values to all (input and out) parameters for all sonos functions. Making is so much easier to show these samples as well.

Now we just need a group effort in adding that data.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the main branch (left side). Also you should start your branch off svrooij/sonos-api-docs/main.
  • Check your code additions will fail neither code linting checks nor unit test. (mine sometimes also fail, will probably ignore the lint failures)
  • If you changed the documentation.json be sure to also regenerate the services files.
  • The docs/services/index.md and the docs/services/*.md files should not be manually changed, only with the generator.

💔 Thank you!

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for sonos-upnp ready!

Name Link
🔨 Latest commit d0f1479
🔍 Latest deploy log https://app.netlify.com/sites/sonos-upnp/deploys/65cc846de930930008fae074
😎 Deploy Preview https://deploy-preview-44--sonos-upnp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@svrooij svrooij merged commit ec52061 into main Feb 14, 2024
12 of 16 checks passed
@svrooij svrooij deleted the feat/sample-value branch February 14, 2024 09:17
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant