server: Don't require trailing slash at the end of request paths #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-jplatte
force-pushed
the
jplatte/normalize-path
branch
from
70d54e1
to
410a927
Compare
svix-aaron1011
approved these changes
Mar 13, 2024
svix-jplatte
added a commit
that referenced
this pull request
Mar 13, 2024
Now that we normalize paths, any routes registered with a slash at the end can't actually be hit at all as the trailing slash will be stripped before the request goes to the router. Follow-up to #1270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1254.