-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update badges in README.md #2041
Conversation
Add NPM and Discord logos. Label Discord badge as "Discord". Set Discord badge Color to 5865F2, Discord's official "Blurple" color.
Who maintains brew svgo package and how it works? Does it need node.js? |
Here. This says it needs node 22.3.0. |
Hmm, seems like the bottle is there for 7 years. Seems like updated automatically, probably from the github release. |
I'm not seeing the benefit to most of this. It adds bloat to the README with information no one is asking for, and most of it is readily available at the links we do have. UX extends to project documentation and the README too, and this overall offers a worse experience for people learning about the project. For example, scattering around icons and colors everywhere with meaningless stats doesn't help anyone, it just distracts them from the more important information we actually do want them to read. Some things I do like about this PR:
Some things I disliked:
I originally closed the PR as I was distracted by the cluster of badges, but I do realize now that there was some good in it too. If you'd like, you're welcome to open another PR that addresses some of the issues raised. Edit: As an aside, before adding more badges from shields.io, I'd been keen to see them address badges/shields#5497 and badges/shields#9916. Even I find the badges hard/uncomfortable to read, even though I love the project. |
Add NPM and Discord logos. Label Discord badge as "Discord". Set Discord badge Color to 5865F2, Discord's official "Blurple" color.