Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize MS map_ BIF names and document grammar. #3

Open
wants to merge 1 commit into
base: sverker/erts/match-spec-map-bifs
Choose a base branch
from

Conversation

christhekeele
Copy link

@christhekeele christhekeele commented Feb 20, 2024

Picked up and played with erlang#7326 a little @sverker, here's a PR form of some of my thoughts.

  • Renames maps_put and maps_remove to map_put and map_remove

    The reasoning being:

    • The pre-existing map_get call allowed in matchspecs today is singular
    • This is to mirror the auto-imported map_get BIF in the erlang module; in the future if map put/remove BIFs are added to erlang they would be named similarly too
  • Allows map_put and map_remove in trace matchspec bodies

    • I think we may as well allow modification of maps used in tracing; ex. adding some sort of metadata into a map being used as an emitted message in certain trace patterns
  • Separates these functions from action functions in both documentation and implementation

  • Updates the matchspec grammar docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant