Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French (fr): Revert remainder of NBSP characters #996

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

johnnyshields
Copy link
Contributor

@johnnyshields johnnyshields commented Apr 18, 2022

In 6f21c25, @benoittgt partially reverted "thin spaces" i.e. NBSP characters from French (fr) locale.

I do not understand the reason for a "partial" revert. It's not explained in the commit, and there seems to be no consistent logic regarding which NBSP chars were reverted. For example:

      too_long:
        other: est trop long (pas plus de %{count} caractères) # not reverted 🤷 
      too_short:
        other: est trop court (au moins %{count} caractères)   # reverted

This PR reverts all NBSP chars from fr, and in the future if the maintainers would like to make some consistent rule on where/how NBSP should in which locales, let's re-apply it at that time.

@johnnyshields johnnyshields changed the title French: Revert remainder of NBSP characters French (fr): Revert remainder of NBSP characters Apr 18, 2022
@pama
Copy link
Collaborator

pama commented Apr 25, 2022

That was reverted due to #889 (comment) I believe.

In my opinion, rails-i18n should not address nbsp, at all (for some reasons here #881 and here #889)

@pama
Copy link
Collaborator

pama commented Jun 9, 2022

@MoskitoHero MoskitoHero merged commit 36885a4 into svenfuchs:master Jun 14, 2022
@johnnyshields johnnyshields deleted the french-nbsp branch August 23, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants