Skip to content

Conversation

Ocean-OS
Copy link
Member

Closes #16927.
We had assumed that all keyed {#each ...} blocks would have an as clause, and didn't throw if this assumption failed, nor did we document this. This fixes that.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: 08a24f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16963

@Rich-Harris
Copy link
Member

Rich-Harris commented Oct 16, 2025

This wasn't quite right — the pattern argument always needs to be present, even if it's just placeholder, otherwise the index argument is given in the wrong position.

Fixed that but in the course of adding a test realised that there's actually a very good reason not to do this — if the key function can't reference the item, then it can't do anything useful. So I think we should probably just forbid key functions for each blocks without an as clause

@Rich-Harris
Copy link
Member

opened #16966

@paoloricciuti
Copy link
Member

Closing because of #16966

@Ocean-OS Ocean-OS deleted the gh-16927 branch October 17, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#each blocks without an item + key expression cause a runtime error

3 participants