Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for :has(...) as part of :root #14229

Merged
merged 8 commits into from
Nov 14, 2024
Merged

fix: account for :has(...) as part of :root #14229

merged 8 commits into from
Nov 14, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 8, 2024

We previously marked all :root selectors as global-like, which excempted them from further analysis. This causes problems:

  • things like :not(...) are never visited and therefore never marked as used -> we gotta do that directly when coming across this
  • :has(...) was never visited, too. Just marking it as used is not enough though, because we might need to scope its contents

Therefore the logic is enhanced to account for these special cases. Fixes #14118

While fixing this I cleaned up some inconsistencies in what we mark as global. This simplified code and fixed some adjacent bugs, which conindicentally also fixes #14189

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

We previously marked all `:root` selectors as global-like, which excempted them from further analysis. This causes problems:
- things like `:not(...)` are never visited and therefore never marked as used -> we gotta do that directly when coming across this
- `:has(...)` was never visited, too. Just marking it as used is not enough though, because we might need to scope its contents

Therefore the logic is enhanced to account for these special cases. Fixes #14118
@dummdidumm dummdidumm marked this pull request as ready for review November 8, 2024 20:23
Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 261d6f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14229

@Thiagolino8
Copy link

Still breaks with nesting + &:

@dummdidumm dummdidumm merged commit 45fa678 into main Nov 14, 2024
11 checks passed
@dummdidumm dummdidumm deleted the root-has-fix branch November 14, 2024 10:24
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect CSS Output for :not() Selector :root:has() unused false positive
3 participants