-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: page response missing CSP and Link headers when return promise in load
#12418
Conversation
🦋 Changeset detectedLatest commit: c8eb682 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as duplicate.
This comment was marked as duplicate.
Thank you for the PR. I think it's good to merge, but is it possible if we add some kind of test such as one that checks that the CSP headers are included in the server response? Maybe as an additional test in this test suite: kit/packages/kit/test/apps/options/test/test.js Lines 115 to 139 in 6f273fb
|
@eltigerchino sure! |
Thank you so much! |
closes #11801
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits