chore: co-locate image assets in template

[sacrosanctic]

closes #859

In addition:

• add comment explaining why svelte.config.ts isn't used
• minor typos and fixes

I've grouped relevant changes together for easy git revert.

[changeset-bot]

⚠️ No Changeset found

Latest commit: f020dd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@860

npx https://pkg.pr.new/sveltejs/cli/sv@860

commit: f020dd5

[jycouet]

Suggested change

	// ecosystem doesn't support `svelte.config.ts` https://github.com/sveltejs/cli/issues/816#issuecomment-3568032867
	// but the user may have opt in to it
	// `sv` uses `svelte.config.js` by default
	// but users may have changed to `svelte.config.ts`

[sacrosanctic]

What about like this, or is it too cheeky? 1cc1d50

[jycouet]

It's not @deprecated! Maybe in 2 years it will be the default! (I don't know ^^)
It's just not the default today.

I'm not sure why you want to point it out absolutely?
It feels that you don't like this default?

[jycouet]

Hi @sacrosanctic, thx for looking at this.

I'll try to organize feedback ^^

A/ colocate assets

• After this, there is nothing in lib folder and we do'nt show $lib alias that is a nice default
• there is a ton of files directly under /routes and it's not that pretty. (subjective)
• what about a (home) level? in order to:
  • have less stuff just under /routes
  • show organization folder

• what about keeping svelte-logo.svg in lib/images and use it in Header.svelte and as favicon as well?

I'm not 100% sure we want all this, but I would look into this direction if there is something to change.
Maybe @benmccann has more opinion on this?

B/ consistent names
Is it way more consistent? 😅

• just before it's xxxTS
• this is tsXxx
• just after it's xxx without the js

C/ easier to read
I remember not linking writing this, haha.

D/ use commonFilePaths
Looks good 👍

E/ comment on no ecosystem support for svelte.config.ts
I'm not a big fan of the 3 mentions & link to github comment. I would put something like my suggestion and remove the 2 other places

F/ typo
Thank you 😁 🫣

[sacrosanctic]

I figured there would be a discussion about the assets, so I opened an issue for it. I guess it doesn't matter where the discussion happens.

what about a (home) level?

I've personally used /FILES before, it would be nice to come up with an agreeable convention.

[benmccann]

Maybe _assets if we want to put just the images and .css there or perhaps _includes for everything including those and the components. I asked in #ambassadors to see if others have ideas

[sacrosanctic]

_include sounds pretty good as a catch-all folder name. But I think we also still have a reference to $lib/... to showcase it. what about a $lib/util.js#dateFormat function?

[jycouet]

Today

H move page things under (home)

C co-locate assets & remove favicon.svg in favor of svelte-logo.svg

i _includes folder to group things

Like this, $lib is still here and we don't have to "make it up" ^^

[benmccann]

_includes got the most votes among ambassadors and it sounds like you like it as well, so I say we go with that

[benmccann]

Actually, it sounds like _assets would be preferred to _includes. It wasn't part of the vote, but enough people are speaking up that it seems like the better option

[benmccann]

I'm really going back and forth on this, but I just changed my vote to keep things as they are today without any folder for additional organization, which now puts that option in the lead due to the low number of voters. The reason I'm changing my mind is that I noticed the screenshot is not how things appear for me. In the screenshot, files are appearing before folders. I think that makes things look messier because you have to scan through all the files to see the list of folders. That originally caused me to vote for having more organization. However, that's not how things appear for me. And it's not how things appear by default as far as I can tell

[jycouet]

I'm also in favor of not changing organization for demo atm.

The PR is still good for the other things you suggest @sacrosanctic
Let's clean it and I'll merge 👍