Skip to content

Package submission: Svelte Scroll Tracker #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AsafAgranat
Copy link

🎯 Changes

Package submission: Svelte Scroll Tracker

✅ Checklist

  • [x ] I have given my PR a descriptive title
  • [x ] I have run pnpm run lint locally on my changes

Toanzzz and others added 30 commits December 16, 2023 13:29
* Update components.json

* fix: format

* Update components.json

* Update components.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Added Vontigo

* Update templates.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
add Svane

Co-authored-by: Lachlan Collins <[email protected]>
* Update components.json

* Update components.json

* Update components.json

* Update components.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Update components.json

* Update components.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
Co-authored-by: Lachlan Collins <[email protected]>
added @radar-azdelta/svelte-datatable

Co-authored-by: Lachlan Collins <[email protected]>
* Update templates.json

Add Tablog, a minimalistic blog theme.

* Update templates.json

* Update templates.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Added 3 new components

* Update components.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
Co-authored-by: Lachlan Collins <[email protected]>
* SveDev

* Update templates.json

* Update templates.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Add @mavthedev/svodals

* remove from tools

* Update components.json

* Update src/routes/components/components.json

Co-authored-by: MacFJA <[email protected]>

---------

Co-authored-by: MaverickQuill <[email protected]>
Co-authored-by: MacFJA <[email protected]>
Co-authored-by: Lachlan Collins <[email protected]>
Add svelte-pin-input

Co-authored-by: Lachlan Collins <[email protected]>
* Add sveltepress

* Update templates.json

* update stars

* Update templates.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Add Skinny Pug starter template

I would like to submit my starter template to the templates page.

* Update templates.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Added svelte-unicons in Components

* Update components.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Add firebase adapter for sveltekit

* Update components.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Update components.json

* Formatting

* Update src/routes/components/components.json

Co-authored-by: MacFJA <[email protected]>

* Update components.json

---------

Co-authored-by: MacFJA <[email protected]>
Co-authored-by: Lachlan Collins <[email protected]>
* Update templates.json

* Update templates.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Update components.json

* Reduce number of tags

---------

Co-authored-by: Lachlan Collins <[email protected]>
* Update components.json

* Update components.json

* Update components.json

* Update components.json

---------

Co-authored-by: Lachlan Collins <[email protected]>
github-actions bot and others added 24 commits February 17, 2025 22:36
* add svelte-inspect-value

* lint fix
* feat:  Add @wj/dataview to list of packages

* chore: lint packages.json

* fix:  Change scope to available one

* feat: Add @wjfe/n-savant
* Add 'terminal style' website to `templates.json`

* style(templates): format categories in JSON for consistency

* refactor(templates): simplify categories list in templates.json
@MacFJA MacFJA added the need formatting The PR need to be formatted label May 6, 2025
@AsafAgranat
Copy link
Author

This is probably my fault. I apologize if so. I did lint it locally though. perhaps I overlooked something. What should be the course of action here? shall I start over and create a new pull request?

@MacFJA
Copy link
Collaborator

MacFJA commented May 7, 2025

No, you don't need to create a new Pull Request.

I also did run the lint locally, and it also pass without an issue.
I will take a deeper look at it

EDIT: I wasn't looking at the rigth branch

Comment on lines +3296 to +3299
"categories": [
"user-interaction",
"ui-components"
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"categories": [
"user-interaction",
"ui-components"
]
"categories": ["user-interaction", "ui-components"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need formatting The PR need to be formatted
Projects
None yet
Development

Successfully merging this pull request may close these issues.