Alternative solution for components.json, templates.json and tools.json.
#393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sveltesociety-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I added your idea to the discussion #318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I noticed there are a lot of PRs having merge conflicts because another PR is merged with changes in
components.json,templates.jsonortools.json. Resulting in asking the contributors every time to rebase their PR. This is not very efficient and maintaining this can be a pain.Solution
Move each "repo" to its own JSON files.
To test this I started by moving the last added one to a JSON file. I think we could easily create a script for migrating all items in the JSON files to their own JSON files. But to make sure it is working with the current open PRs I kept the current JSON files for now.
Notes
The current
updateStars.jsis not working with this setup.I recommend removing this script and extending the "page load data" scripts I created for tools, templates, and components. We could fetch the GitHub stars there. So they will be updated every build. This will fixes #217