feat: Add FiniteStateMachine #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c9fd7f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
A lil' demo video of the demo at the top of the docs: CleanShot.2024-07-02.at.16.49.32.mp4 |
|
Could you capitalize the types in the example code? It's a typescript convention. |
TGlide
requested changes
Jul 2, 2024
packages/runed/src/lib/utilities/FiniteStateMachine/FiniteStateMachine.svelte.ts
Show resolved
Hide resolved
packages/runed/src/lib/utilities/FiniteStateMachine/FiniteStateMachine.svelte.ts
Outdated
Show resolved
Hide resolved
packages/runed/src/lib/utilities/FiniteStateMachine/FiniteStateMachine.svelte.ts
Show resolved
Hide resolved
packages/runed/src/lib/utilities/FiniteStateMachine/FiniteStateMachine.svelte.ts
Outdated
Show resolved
Hide resolved
packages/runed/src/lib/utilities/FiniteStateMachine/FiniteStateMachine.svelte.ts
Outdated
Show resolved
Hide resolved
Thanks @TGlide for the excellent review.
|
@TGlide thanks, what a lovely review. I fixed all the things except for the generic vs type assertion. I don't have a better idea, but from a DX perspective, I definitely want the current state to be of type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
useFSMrune that allows you to create minimalistic finite state machines.Ported over from https://github.com/githubnext/tiny-svelte-fsm (which was already MIT, and I'm the author there). I made a couple of minor fixes along the way as well, mostly to enable people to call
.debouncein actions and lifecycle handlers.This PR includes:
✅ Docs with an interactive demo and examples
✅ Tests
Per our conversation in the Svelte Discord: