Upstream codereview changes #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHP code has been refactored to adhere to PSR-1 Coding Standards. This includes adding comprehensive function docblocks for 'activate', 'deactivate', and 'bootstrap' functions, as well as correcting the structure to allow for PHP CodeSniffer's PSR1 rules. Furthermore, PHP CodeSniffer's warning for side effects has been ignored on the first line of script.
# Conflicts: # htmxpress.php
|
Needs tested still. |
svandragt
commented
Jan 10, 2024
Comment on lines
-59
to
-61
| if (empty($paths)) { | ||
| $paths[] = dirname( __FILE__, 2 ) . "/templates/"; | ||
| } |
There was a problem hiding this comment.
Oops I removed the demo templates registration here.
svandragt
commented
Jan 10, 2024
| $wp_query->set_404(); | ||
| status_header( 404 ); | ||
| } | ||
| return $template_loaded; |
There was a problem hiding this comment.
The code is not testing for 404 here, verify this is working correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've used the plugin on a project and I've upstreamed code review changes.