-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
@SVilgelm Thank you for the review. I'll finalyse this work into the next days. I'm also waiting for a fix on marshmallow itself marshmallow-code/marshmallow#1429 |
sure |
f069e30
to
1b55373
Compare
1b55373
to
771aced
Compare
@SVilgelm Code fxed but still waiting for marshmallow-code/marshmallow#1429 (testsuite works with this fix on marshmallow...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great works, thank you! But please remove changes for CnahgeLog
@@ -1,6 +1,8 @@ | |||
CHANGES | |||
======= | |||
|
|||
* Drop support for marshmallow 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove changes in this file. ChangeLoge will be generated automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^^ please revert. The bump version script automatically generates the change log file
Any progress? I would love to this land soon |
@Sytten Unfortunately my PR on marshmallow remains without response... marshmallow-code/marshmallow#1429. Can you review this PR? This may help to move things forward. |
Since PyYaml 5.2, yaml.UnsafeLoader must be used instead of yaml.FullLoader because deserializing objects is exploitable and can run arbitrary code.
@SVilgelm I implemented the propagation of the 'unknow' parameter at loading time as part of the marshmallow-object API to move forward with marshamallow-object... |
@@ -1,6 +1,8 @@ | |||
CHANGES | |||
======= | |||
|
|||
* Drop support for marshmallow 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^^ please revert. The bump version script automatically generates the change log file
depends on: marshmallow-code/marshmallow#1429