Skip to content
This repository has been archived by the owner on Jan 28, 2022. It is now read-only.

Imp: Drop support for marshmallow 2 #68

Merged
merged 3 commits into from
Jan 3, 2020

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Oct 17, 2019

Copy link
Member

@SVilgelm SVilgelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

.travis.yml Show resolved Hide resolved
ChangeLog Show resolved Hide resolved
@lmignon
Copy link
Contributor Author

lmignon commented Oct 25, 2019

@SVilgelm Thank you for the review. I'll finalyse this work into the next days. I'm also waiting for a fix on marshmallow itself marshmallow-code/marshmallow#1429

@SVilgelm
Copy link
Member

sure

@lmignon lmignon force-pushed the master-marshmallow3 branch from f069e30 to 1b55373 Compare November 2, 2019 12:06
@lmignon lmignon force-pushed the master-marshmallow3 branch from 1b55373 to 771aced Compare November 2, 2019 12:11
@lmignon
Copy link
Contributor Author

lmignon commented Nov 2, 2019

@SVilgelm Code fxed but still waiting for marshmallow-code/marshmallow#1429 (testsuite works with this fix on marshmallow...)

Copy link
Member

@SVilgelm SVilgelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works, thank you! But please remove changes for CnahgeLog

@@ -1,6 +1,8 @@
CHANGES
=======

* Drop support for marshmallow 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changes in this file. ChangeLoge will be generated automatically

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^ please revert. The bump version script automatically generates the change log file

@Sytten
Copy link

Sytten commented Nov 23, 2019

Any progress? I would love to this land soon

@lmignon
Copy link
Contributor Author

lmignon commented Nov 25, 2019

@Sytten Unfortunately my PR on marshmallow remains without response... marshmallow-code/marshmallow#1429. Can you review this PR? This may help to move things forward.

@lmignon lmignon changed the title [WIP] Imp: Drop support for marshmallow 2 Imp: Drop support for marshmallow 2 Jan 3, 2020
Since PyYaml 5.2, yaml.UnsafeLoader must be used instead of yaml.FullLoader because deserializing objects is exploitable and can run arbitrary code.
@lmignon
Copy link
Contributor Author

lmignon commented Jan 3, 2020

@SVilgelm I implemented the propagation of the 'unknow' parameter at loading time as part of the marshmallow-object API to move forward with marshamallow-object...
This PR is now ready for review and merge...

@@ -1,6 +1,8 @@
CHANGES
=======

* Drop support for marshmallow 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^ please revert. The bump version script automatically generates the change log file

@SVilgelm SVilgelm merged commit 506b771 into sv-tools:master Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants