-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.21 #53
Conversation
f40a09e
to
cf138bf
Compare
The change to reverseproxy.go to make tests pass came from @marsam on GitHub.
cf138bf
to
8618542
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the PR! Had a quick question/comment below.
@suyashkumar As you noted in your review, the tests pass on go 1.21 (tested using Act) if one removes the if statement that sets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
As go 1.19 has reached End of Life, I propose we update to go 1.21.
This PR changes the version in the
.mod
file 1 line to make tests pass. The patch was done by marsam in the nixpkgs repository: NixOS/nixpkgs#282237I also successfully proxied my website, so it seems there are no breaking changes. What other testing needs to be done?