Skip to content

Commit

Permalink
Update go to 1.18 (#244)
Browse files Browse the repository at this point in the history
  • Loading branch information
suyashkumar authored Aug 24, 2022
1 parent 836cc53 commit 0528e8c
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 19 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/bench_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@ jobs:
build:
name: Benchmark (PR)
runs-on: ubuntu-latest
env:
GOBIN: /home/runner/go
steps:

- name: Set up Go 1.15
uses: actions/setup-go@v2
- name: Set up Go 1.18
uses: actions/setup-go@v3
with:
go-version: 1.15
go-version: 1.18
id: go

- name: Check out code
Expand All @@ -21,8 +22,7 @@ jobs:
- name: Benchmark against GITHUB_BASE_REF
run: |
export PATH=$PATH:$GOBIN
go get golang.org/x/perf/cmd/benchstat
go install golang.org/x/perf/cmd/benchstat@latest
echo "New Commit:"
git log -1 --format="%H"
go test -bench=. -benchtime=.75s -count=8 > $HOME/new.txt
Expand All @@ -31,5 +31,5 @@ jobs:
echo "Base Commit:"
git log -1 --format="%H"
go test -bench=. -benchtime=.75s -count=8 > $HOME/old.txt
benchstat $HOME/old.txt $HOME/new.txt
$GOBIN/benchstat $HOME/old.txt $HOME/new.txt
13 changes: 7 additions & 6 deletions .github/workflows/bench_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ jobs:
build:
name: Benchmark (push)
runs-on: ubuntu-latest
env:
GOBIN: /home/runner/go
steps:
- name: Set up Go 1.15
uses: actions/setup-go@v2
- name: Set up Go 1.18
uses: actions/setup-go@v3
with:
go-version: 1.15
go-version: 1.18
id: go

- name: Check out code
Expand All @@ -20,8 +22,7 @@ jobs:
- name: Benchmark (against HEAD~1)
run: |
export PATH=$PATH:$GOBIN
go get golang.org/x/perf/cmd/benchstat
go install golang.org/x/perf/cmd/benchstat@latest
echo "New Commit:"
git log -1 --format="%H"
go test -bench=. -benchtime=.75s -count=8 > $HOME/new.txt
Expand All @@ -30,4 +31,4 @@ jobs:
echo "Base Commit:"
git log -1 --format="%H"
go test -bench=. -benchtime=.75s -count=8 > $HOME/old.txt
benchstat $HOME/old.txt $HOME/new.txt
$GOBIN/benchstat $HOME/old.txt $HOME/new.txt
6 changes: 3 additions & 3 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ jobs:
runs-on: ubuntu-latest
steps:

- name: Set up Go 1.15
uses: actions/setup-go@v2
- name: Set up Go 1.18
uses: actions/setup-go@v3
with:
go-version: 1.15
go-version: 1.18
id: go

- name: Check out code
Expand Down
6 changes: 4 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
module github.com/suyashkumar/dicom

go 1.13
go 1.18

require (
github.com/golang/mock v1.4.4
github.com/google/go-cmp v0.5.2
golang.org/x/text v0.3.0
golang.org/x/text v0.3.7
)

require golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 // indirect
3 changes: 2 additions & 1 deletion go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACk
golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg=
golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
golang.org/x/text v0.3.7 h1:olpwvP2KacW1ZWvsR7uQhoyTYvKAupfQrRGBFM352Gk=
golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
golang.org/x/tools v0.0.0-20190425150028-36563e24a262/go.mod h1:RgjU9mgBXZiqYHBnxXauZ1Gv1EHHAz9KjViQ78xBX0Q=
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=

0 comments on commit 0528e8c

Please sign in to comment.