Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU-8677zztjz - move code into the gem rather than hot patching it in SC #25

Open
wants to merge 15 commits into
base: feature/move-code-into-the-gem-rather-than-hot-patching-it-in-SC_CU-8677zztjz
Choose a base branch
from
Open

CU-8677zztjz - move code into the gem rather than hot patching it in SC #25

wants to merge 15 commits into from

Conversation

NewAlexandria
Copy link
Member

  • reverts some of the existing changes for Sidekiq
  • develops a new base class that optionally loads sidekiq if it's present in the parent app
  • There is one outstanding issue with the loading of SyncShipmentJob, where it does not have the same inheritance as it should (like ScheduleShipmentSyncsJob):

image

@NewAlexandria NewAlexandria requested a review from a team as a code owner June 8, 2023 00:52
@NewAlexandria
Copy link
Member Author

Task linked: CU-8677zztjz move code into the gem rather than hot patching it in SC

@NewAlexandria NewAlexandria changed the base branch from main to feature/move-code-into-the-gem-rather-than-hot-patching-it-in-SC_CU-8677zztjz June 8, 2023 00:52
@NewAlexandria NewAlexandria force-pushed the refactor/move-code-into-the-gem-rather-than-hot-patching-it-in-SC_CU-8677zztjz branch from 5ecdf59 to 7f37888 Compare June 8, 2023 02:50
@NewAlexandria NewAlexandria mentioned this pull request Jun 8, 2023
Open
@NewAlexandria NewAlexandria force-pushed the feature/move-code-into-the-gem-rather-than-hot-patching-it-in-SC_CU-8677zztjz branch from 475a783 to c2e011d Compare August 3, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NewAlexandria @mrshahsuvie