Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] sustainability_hr_expense_report: return False if no account #234

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

jguenat
Copy link
Contributor

@jguenat jguenat commented Jan 9, 2025

account_id might not be defined

@sustainabilitybot
Copy link
Collaborator

Hi @BonnetAdam,
some modules you are maintaining are being modified, check this out!

@jguenat jguenat changed the title [FIX] sustainability_hr_expense_report: return False if no account [17.0][FIX] sustainability_hr_expense_report: return False if no account Jan 9, 2025
@jguenat
Copy link
Contributor Author

jguenat commented Jan 10, 2025

/ocabot merge minor

@sustainabilitybot
Copy link
Collaborator

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-234-by-jguenat-bump-minor, awaiting test results.

@sustainabilitybot sustainabilitybot merged commit 29b4506 into 17.0 Jan 10, 2025
2 checks passed
@sustainabilitybot
Copy link
Collaborator

Congratulations, your PR was merged at 87ea8d0. Thanks a lot for contributing to sustainability-suite. ❤️

@sustainabilitybot sustainabilitybot deleted the 17.0-fix-purchase-no-account branch January 10, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants