draft: [IMP|FIX] Improve performance and fix previous problems #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… carbon_factor_id set
…ce when none are found
|
Hi @jacopobacci, @jguenat, @BonnetAdam, |
jguenat
requested changes
Jan 10, 2025
Comment on lines
413
to
+440
| def has_valid_carbon_fallback(self, carbon_type: str): | ||
| self.ensure_one() | ||
| return self[f"carbon_{carbon_type}_fallback_reference"] and self[ | ||
| f"carbon_{carbon_type}_fallback_reference" | ||
| ].has_valid_carbon_value(carbon_type) | ||
| field_name = f"carbon_{carbon_type}_fallback_reference" | ||
| need_re_call = False | ||
| fallback_reference = getattr(self, field_name) or False | ||
|
|
||
| has_valid_carbon_value = False | ||
| if fallback_reference: | ||
| has_valid_carbon_value = ( | ||
| fallback_reference.has_valid_carbon_value(carbon_type) or False | ||
| ) | ||
|
|
||
| # Condition explained: if fallback_reference is not set and the current record is not the last one in the list of CARBON_MODELS | ||
| if ( | ||
| not fallback_reference | ||
| and self._name not in CARBON_MODELS | ||
| and self._name != CARBON_MODELS[-1] | ||
| ): | ||
| _logger.warning( | ||
| f"Fallback reference for '{carbon_type}' is not set on {self}. Setting it to the company." | ||
| ) | ||
| setattr(self, field_name, self.env.company) | ||
| need_re_call = True | ||
|
|
||
| if need_re_call: | ||
| return self.has_valid_carbon_fallback(carbon_type) | ||
|
|
||
| return fallback_reference and has_valid_carbon_value |
There was a problem hiding this comment.
It's not the correct place to do that. Did you try with _get_carbon_compute_default_record and/or get_carbon(in/out)_fallback_records() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
For the bug where we cannot find a fallback reference, here are the issues: #220
Self proofreading checklist
and meets the project's coding standards?
reflect your changes?
run upon committing to catch any potential issues?
Test Instructions
I haven't tested it out yet, BCH are going to do a deep down search if everything checked out
Additional Notes
Nope all good