-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] sustainability_product_label_print: add carbon on printed labels #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguenat
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Introduce a new module, sustainability_product_label_print, to enhance product labels with CO2e information. This module allows users to activate CO2e data on printed labels from the Sustainability settings. The addition includes necessary templates and configurations to support various label formats, ensuring flexibility and adaptability for different printing needs. This enhancement aims to provide more transparent and informative product labeling, aligning with sustainability goals.
…y and barcode integration Improve product label templates by adding carbon value display and integrating barcode functionality. This change enhances the visual presentation and provides more detailed product information, supporting sustainability efforts.
…s to enhance clarity and maintainability
Introduce a new configuration setting to enable the display of CO2e values on printed product labels. This enhancement allows users to better communicate the environmental impact of products, aligning with sustainability goals.
…y and remove redundant template Simplify the display of carbon values by consolidating the format and removing unnecessary elements. Eliminate the redundant template `report_simple_label4x12_no_price_inherit` to streamline the code and improve maintainability.
…lue and unit to improve readability and consistency across the product label print template
…oduct_template_templates.xml and updating product_product_templates.xml for carbon value display
jacopobacci
force-pushed
the
17.0-jab-print-carbon-product-label
branch
from
December 12, 2024 07:50
3127717
to
346039b
Compare
BonnetAdam
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t we want to have multiple templates? A bit more configuration, or is it good to go? Just 1-2 comments, otherwise looks good.
BonnetAdam
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues