Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] sustainability_product_label_print: add carbon on printed labels #217

Merged
merged 9 commits into from
Dec 12, 2024

Conversation

jacopobacci
Copy link
Contributor

Related Issues

@jacopobacci jacopobacci added the enhancement New feature or request label Dec 6, 2024
@jacopobacci jacopobacci requested a review from jguenat December 6, 2024 09:03
@jacopobacci jacopobacci self-assigned this Dec 6, 2024
@jguenat jguenat requested a review from remyz17 December 11, 2024 14:20
Copy link
Contributor

@jguenat jguenat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Introduce a new module, sustainability_product_label_print, to enhance
product labels with CO2e information. This module allows users to
activate CO2e data on printed labels from the Sustainability settings.
The addition includes necessary templates and configurations to support
various label formats, ensuring flexibility and adaptability for
different printing needs. This enhancement aims to provide more
transparent and informative product labeling, aligning with
sustainability goals.
…y and barcode integration

Improve product label templates by adding carbon value display
and integrating barcode functionality. This change enhances
the visual presentation and provides more detailed product
information, supporting sustainability efforts.
Introduce a new configuration setting to enable the display of CO2e
values on printed product labels. This enhancement allows users to
better communicate the environmental impact of products, aligning with
sustainability goals.
…y and remove redundant template

Simplify the display of carbon values by consolidating the format
and removing unnecessary elements. Eliminate the redundant template
`report_simple_label4x12_no_price_inherit` to streamline the code
and improve maintainability.
…lue and unit to improve readability and consistency across the product label print template
…oduct_template_templates.xml and updating product_product_templates.xml for carbon value display
@jacopobacci jacopobacci force-pushed the 17.0-jab-print-carbon-product-label branch from 3127717 to 346039b Compare December 12, 2024 07:50
Copy link
Member

@BonnetAdam BonnetAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t we want to have multiple templates? A bit more configuration, or is it good to go? Just 1-2 comments, otherwise looks good.

@jacopobacci jacopobacci merged commit 0f27725 into 17.0 Dec 12, 2024
2 checks passed
@jacopobacci jacopobacci deleted the 17.0-jab-print-carbon-product-label branch December 12, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Label - Add CO2 value
3 participants