-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional file protection + backup exclusion to FileLoggerable #93
base: main
Are you sure you want to change the base?
Conversation
I also added flushMode and writeMode to FileRotationLogger because those seem to be missing (FileLogger supports this). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 97.18% 97.26% +0.08%
==========================================
Files 12 12
Lines 639 658 +19
==========================================
+ Hits 621 640 +19
Misses 18 18 ☔ View full report in Codecov by Sentry. |
Hello, can I get the kill and background mode logs if I use this package? please anyone, help me |
Hi @sushichop, do you think this would be a good idea to merge into main? Do you think it makes sense to put these initializer arguments behind a compile-time check so that this can be mergeable? If so I could make that change. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request and sorry for the late response.
I expect Puppy to work equally well on the Apple Platform, Linux (at least Ubuntu) and Windows out of the box. This is very important for Puppy.
Therefore, it would be good if you made that there are no compilation errors on each OS at least.
@richardhenry it can be wrapped in eg |
@sushichop Thanks, should be fixed — can you trigger another test run? |
This PR adds optional file protection and backup exclusion to FileLogger and FileRotationLogger. To my knowledge, these features are only available on Apple platforms, so the tests I've added will only run on those platforms. Maybe these features should be entirely gated behind compile-time checks? Open to feedback.