Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider an option to keep file extension #37 #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajeshkumar71190
Copy link

#37

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 98.48% // Head: 97.41% // Decreases project coverage by -1.06% ⚠️

Coverage data is based on head (df246c2) compared to base (ffa4ce4).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   98.48%   97.41%   -1.07%     
==========================================
  Files          12       12              
  Lines         463      465       +2     
==========================================
- Hits          456      453       -3     
- Misses          7       12       +5     
Impacted Files Coverage Δ
Sources/Puppy/FileRotationLogger.swift 90.82% <50.00%> (-4.51%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@sushichop sushichop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR🙂

To be precise, I would like to support 4 patterns.

  • keeping extension
    • numbering
    • date_uuid
  • Not keeping extension
    • numbering
    • date_uuid

Therefore, I think it is preferable to add keepExtention as an argument to FileRotationLogger.
Are you interested in trying to implement this?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants