Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Tips and Tricks section to Edge Book and adding the first page for EIB #502

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

Gagrio
Copy link
Contributor

@Gagrio Gagrio commented Nov 27, 2024

Adding a Tips and Tricks section to Edge Book and adding the first page for EIB

@Gagrio
Copy link
Contributor Author

Gagrio commented Nov 27, 2024

@e-minguez new PR here

Copy link
Contributor

@atanasdinov atanasdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, George! I'm glad to see this contribution. I did leave some comments for further iteration but I believe the content is a nice addition.

Could we also link this new tips and tricks page / section in https://documentation.suse.com/suse-edge/3.1/html/edge/components-eib.html?

@Gagrio
Copy link
Contributor Author

Gagrio commented Nov 28, 2024

reworked the document and added a link from EIB component page to it.

@Gagrio Gagrio requested a review from atanasdinov November 29, 2024 17:45
Copy link
Contributor

@rdoxenham rdoxenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work here, @Gagrio! Just a few suggestions, but otherwise I appreciate you taking the time.

@Gagrio Gagrio merged commit de8f70e into main Jan 10, 2025
1 check passed
@Gagrio Gagrio deleted the george branch January 10, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants