Version attributes - Part 3 #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardys
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
lgtm - I agree we'll need to populate the releasenotes manually since we need to maintain current/latest and also historical versions - perhaps we can consider some kind of automated check in future to ensure the versions and the latest z-stream in the releasenotes align
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #495 for more context.
This PR includes the last of the sweeping changes to use attributes for versions. The bottom of the
versions.adocfile shows the list of pages that need to be manually reviewed. I includedreleasenotes.mdin that list rather than attempt to template it, though I may resurrect the old version matrix page and have it pull values from the variables.But this is the last of the major refactoring. Any further work on this should hopefully be less disruptive and not put a pause on others doing docs work.