Standardize SUC Plan naming in 3.1.1 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2024
Merged
hardys
approved these changes
Nov 8, 2024
dprodanov4
approved these changes
Nov 8, 2024
Merged
hardys
pushed a commit
that referenced
this pull request
Nov 11, 2024
* K3s naming standartization * RKE2 naming standartization * OS naming standartization * Rename agent plans to worker * Rename os gitrepo to reflect correct procedure * Standardize OS bundle name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardises the naming for the K8s (RKE2/K3s) and OS SUC Plans so that it is consistent throughout the repository.
This will handle corner-cases where users have SUC Plans for Edge 3.X.Y deployed on a downstream cluster and then deploy SUC Plans for Edge 3.X.Y+1 on the same cluster. Having the same consistent naming throughout Edge versions will block (or at least reduce) the chance that we will have SUC Plans for multiple Edge versions on one downstream cluster. Effectively ensuring that clashes will not occur. What is meant by clashes here is that for some reason the Edge 3.X.Y SUC Plan overrides the changes from the Edge 3.X.Y+1 SUC Plan.
This will be further enforced in the 3.1.1 documentation in a separate PR (#483).
The naming changes have been tested for functionality regressions using the following test cases:
GitRepoandBundleapproachesGitRepoandBundleapproachesGitRepoandBundleapproaches