Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ migrate to TUnit #167

Merged
merged 7 commits into from
Jan 29, 2025
Merged

♻️ migrate to TUnit #167

merged 7 commits into from
Jan 29, 2025

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Jan 22, 2025

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What does this change do?

  • Migrate tests from xUnit to TUnit
  • Refactor test pattern by creating a new ApplySchemaAsync function
  • Define a new constant to disable embedded mode, so that anyone can run tests without having to build the local Rust crates (meaning it will run global tests & remote mode)
  • Create a new bash script to easily disable embedded mode
  • Update readme
  • Fix CI (updated csharpier to the latest version)

What is your testing strategy?

Tested locally via the .NET CLI

Is this related to any issues?

N/A

Have you read the Contributing Guidelines?

@Odonno Odonno changed the title Chore/tunit ♻️ migrate to TUnit Jan 22, 2025
@Odonno Odonno force-pushed the chore/tunit branch 10 times, most recently from 22751c8 to b2c1b8e Compare January 25, 2025 00:30
@Odonno Odonno force-pushed the chore/tunit branch 3 times, most recently from dd95782 to d0d7c8f Compare January 25, 2025 12:55
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.20792% with 21 lines in your changes missing coverage. Please review.

Project coverage is 73.09%. Comparing base (6fd2105) to head (b28db7f).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
...Net/Internals/Cbor/Converters/RecordIdConverter.cs 45.45% 6 Missing ⚠️
.../Internals/Cbor/Converters/RecordIdOfTConverter.cs 0.00% 6 Missing ⚠️
SurrealDb.Net/SurrealDbClient.cs 91.66% 0 Missing and 3 partials ⚠️
...s/Cbor/Converters/JsonPatchDocumentConverterOfT.cs 33.33% 2 Missing ⚠️
...ons/DependencyInjection/SurrealDbOptionsBuilder.cs 50.00% 1 Missing ⚠️
...nals/Cbor/Converters/JsonPatchDocumentConverter.cs 66.66% 1 Missing ⚠️
...r/Converters/JsonPatchDocumentConverterProvider.cs 88.88% 1 Missing ⚠️
...rrealDb.Net/Internals/Cbor/SurrealDbCborOptions.cs 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   69.65%   73.09%   +3.44%     
==========================================
  Files         161      174      +13     
  Lines        6702     7234     +532     
  Branches      775      760      -15     
==========================================
+ Hits         4668     5288     +620     
+ Misses       1689     1645      -44     
+ Partials      345      301      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kearfy kearfy merged commit e46a677 into surrealdb:main Jan 29, 2025
9 checks passed
@Odonno Odonno deleted the chore/tunit branch January 29, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants