Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes from monitoring of 2.0.51-alpha #67

Merged
merged 10 commits into from
Sep 8, 2024
Merged

Various fixes from monitoring of 2.0.51-alpha #67

merged 10 commits into from
Sep 8, 2024

Conversation

ryanwitt
Copy link
Member

@ryanwitt ryanwitt commented Jul 10, 2024

Closes https://github.com/suredone/suredone/issues/10912

  • Adds validation for prefix/suffixes
  • Fixes bug where .fifo queues were not monitored correctly
  • Removes the --unpair option from idle-queues
  • Makes idle-queues --delete remove orphaned failed and dead queues that are idle
  • Add retries for flaky tests
  • Add test coverage
  • Calculate load feedback more quickly
  • Attempt to fix potential qrlCache bug
  • Fix a bug where too many jobs would get added to the waiting state

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.82%. Comparing base (4e51985) to head (d385ec3).
Report is 11 commits behind head on v2.

Files with missing lines Patch % Lines
src/monitor.js 0.00% 1 Missing and 1 partial ⚠️
src/qrlCache.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2      #67      +/-   ##
==========================================
+ Coverage   69.67%   76.82%   +7.14%     
==========================================
  Files          12       12              
  Lines        1141     1139       -2     
  Branches      277      274       -3     
==========================================
+ Hits          795      875      +80     
+ Misses        266      203      -63     
+ Partials       80       61      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanwitt ryanwitt merged commit 578bae4 into v2 Sep 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant